From f54b87482961f07b94f9a0997944cb4f0175d2ef Mon Sep 17 00:00:00 2001 From: Eduardo Date: Thu, 30 Nov 2023 14:00:01 +0100 Subject: [PATCH] extracted function to reduce code complexity --- page-generator/generator.php | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/page-generator/generator.php b/page-generator/generator.php index afaea9a..3984c5c 100644 --- a/page-generator/generator.php +++ b/page-generator/generator.php @@ -287,9 +287,7 @@ class CodeGenerator // if class not empty add class $filtered_classes = $this->filter_meta_classes($class); - if (!empty($filtered_classes)) { - $html .= ' class="' . implode(' ', $filtered_classes) . '"'; - } + $html .= $this->class_html_or_empty($filtered_classes); $html .= '>'; } elseif (!$is_p_closed && !$open) { @@ -310,8 +308,8 @@ class CodeGenerator // if class not empty and text empty add class $filtered_classes = $this->filter_meta_classes($class); - if (empty($text) && !empty($filtered_classes)) { - $html .= ' class="' . implode(' ', $filtered_classes) . '"'; + if (empty($text)) { + $html .= $this->class_html_or_empty($filtered_classes); } $html .= '>'; @@ -335,8 +333,8 @@ class CodeGenerator $html .= 'filter_meta_classes($class); - if (empty($text) && !empty($filtered_classes)) { - $html .= ' class="' . implode(' ', $filtered_classes) . '"'; + if (empty($text)) { + $html .= $this->class_html_or_empty($filtered_classes); } $html .= '>'; @@ -419,9 +417,7 @@ class CodeGenerator // if class not empty add class $filtered_classes = $this->filter_meta_classes($class); - if (!empty($filtered_classes)) { - $html .= ' class="' . implode(' ', $filtered_classes) . '"'; - } + $html .= $this->class_html_or_empty($filtered_classes); // if has title and url = a with title if (!empty($url)) { @@ -454,6 +450,11 @@ class CodeGenerator return $html; } + private function class_html_or_empty(array $filtered_classes): string + { + return !empty($filtered_classes) ? ' class="' . implode(' ', $filtered_classes) . '"' : ""; + } + private function str_val_or_empty(array $arr, string $key): string { return isset($arr[$key]) ? $arr[$key] : ""; -- 2.30.2